Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak notification fetch frequency #3576

Closed
bmesuere opened this issue Apr 30, 2022 · 1 comment · Fixed by #4373
Closed

Tweak notification fetch frequency #3576

bmesuere opened this issue Apr 30, 2022 · 1 comment · Fixed by #4373
Assignees
Labels
chore Repository/build/dependency maintenance high priority Things we want to see implemented soon

Comments

@bmesuere
Copy link
Member

Right now, we check for new notifications every 60 seconds even if the tab is in the background. This can be improved by only checking if the tab is visible and maybe adding some kind of backoff. The good new is that we have already implemented such logic in the auto_reload.ts file.

The reason for this is a substantial server load by the notification controller.
Last week, the notifications accounted for a third of the cpu time:
image

And 2/3 of the number of hits:
image

@bmesuere bmesuere added chore Repository/build/dependency maintenance low priority Thing we want to see implemented at some point labels Apr 30, 2022
@bmesuere bmesuere added this to Roadmap Apr 30, 2022
@bmesuere bmesuere moved this to Unplanned in Roadmap Apr 30, 2022
@bmesuere
Copy link
Member Author

I thought some more about this. Since we load the notifications lazily, we always have an additional notifications hit for every page load. Simply being smarter about the refresh time would help but not a lot.

An alternative is a better cache system and/or keep the latest update time in local storage and don't fetch the notifications on every page load.

@bmesuere bmesuere moved this from Unplanned to Todo in Roadmap May 2, 2022
@bmesuere bmesuere added high priority Things we want to see implemented soon and removed low priority Thing we want to see implemented at some point labels Jan 27, 2023
@jorg-vr jorg-vr self-assigned this Jan 30, 2023
@jorg-vr jorg-vr moved this from Todo to In Progress in Roadmap Jan 31, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Roadmap Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Repository/build/dependency maintenance high priority Things we want to see implemented soon
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants