Only show submissions without a course in the submission overview on the submission detail page

[pdawyndt]

For exercises that have submissions prior to numbering of submissions was introduced, there seems to be an off-by-one error

[jorg-vr]

Odd, still works correctly when I try to reproduce:

Could you link me the specific exercise so I can investigate further?

One potential cause: we number submissions within the context of a course, so it could have happened that 9 submissions happened in the course and 1 happened outside. If this is indeed the cause we should improve the automatically numbered list. (Either by only showing submissions within the same course, or by using the database numbers instead of generated ones)

[pdawyndt]

Just happende again in class with this exercise https://dodona.ugent.be/nl/exercises/837426097/. As you’ll see, these submission are not scopes in a course, so that’s probabilistisch where the issue occurs. Nummering should at leaset be the same on the same page (which is where off by onze occurs).

[pdawyndt]

Also: wouldn’t it be logical to add numbers to all submissions retroactively? Now, submissions prior to release 5.4 have no sequence number.

[jorg-vr]

Ok I found the issue.

One submission was made within the context of a course: https://dodona.ugent.be/nl/submissions/7583516/ and thus numbered separately
Here only submissions within the same course are shown as expected

The other submissions were done without a course context. But their submission overview also shows all submissions that have a course, which results in an incorrect numbering: