Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use URL API in util.js #2614

Closed
niknetniko opened this issue Apr 13, 2021 · 2 comments · Fixed by #2954
Closed

Use URL API in util.js #2614

niknetniko opened this issue Apr 13, 2021 · 2 comments · Fixed by #2954
Assignees
@TimonDB
Labels
enhancement A change that isn't substantial enough to be called a feature low priority Thing we want to see implemented at some point student Things summer interns can do

Comments

@niknetniko
Copy link
Member

The functions updateURLParameter, updateArrayURLParameter, getURLParameter and getArrayURLParameter in util.js can probably be re-implemented using the URL and URL.searchParams APIs. These are supported in all modern browsers: URL and URLSearchParams.
@niknetniko niknetniko added student Things summer interns can do chore Repository/build/dependency maintenance low priority Thing we want to see implemented at some point labels Apr 13, 2021
@bmesuere bmesuere added enhancement A change that isn't substantial enough to be called a feature and removed chore Repository/build/dependency maintenance labels Jun 26, 2021
@TimonDB
Copy link
Contributor

TimonDB commented Aug 3, 2021

I started working on this issue and made a (draft) redesign of getURLParameter, is there a way to locally test if this function still delivers the correct output?

Screenshot from 2021-08-03 16-17-48

@chvp
Copy link
Member

chvp commented Aug 3, 2021 •
edited
Loading

We don't have tests for this file, sadly. You can check where it is used and see if the functionality that uses it still works (e.g. for getURLParameter, it is used by the tab switching code on the course members page).

@TimonDB TimonDB mentioned this issue Aug 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TimonDB TimonDB

Labels
enhancement A change that isn't substantial enough to be called a feature low priority Thing we want to see implemented at some point student Things summer interns can do
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-implement util functions using URL API dodona-edu/dodona
4 participants
@bmesuere @niknetniko @chvp @TimonDB