Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto refresh is broken on pagination on questions index #2544

Closed
niknetniko opened this issue Mar 11, 2021 · 4 comments
Closed

Auto refresh is broken on pagination on questions index #2544

niknetniko opened this issue Mar 11, 2021 · 4 comments
Labels
bug Something isn't working medium priority Things we want to see implemented relatively soon

Comments

@niknetniko
Copy link
Member

On the /questions page, there is an option to auto-reload the table.
The pagination is remote: true, so the page param is not updated in the URL (there is no &page=2 or anything like that).
The refresh uses the URL, so it always refreshes page 1 (?page=1).

Some solutions:

  • Include the pagination param in the URL
  • Remove the refresh option, since I'm not sure it is that useful
@niknetniko niknetniko added the bug Something isn't working label Mar 11, 2021
@pdawyndt
Copy link
Contributor

I consider the refresh option to be very useful on the questions page.

@chvp
Copy link
Member

chvp commented Mar 11, 2021

@pdawyndt this is not about the course questions page, but the new question overview page.

@pdawyndt
Copy link
Contributor

OK, thanks for the clarification.

@bmesuere bmesuere added the low priority Thing we want to see implemented at some point label Apr 16, 2021
@bmesuere bmesuere added this to Roadmap Sep 20, 2021
@bmesuere bmesuere moved this to Unplanned in UI/UX improvements Feb 23, 2022
@jorg-vr jorg-vr assigned jorg-vr and unassigned jorg-vr Feb 25, 2022
@bmesuere bmesuere added medium priority Things we want to see implemented relatively soon and removed low priority Thing we want to see implemented at some point labels Mar 3, 2022
@bmesuere bmesuere moved this to Todo in Roadmap Apr 17, 2022
@jorg-vr
Copy link
Contributor

jorg-vr commented May 24, 2022

closed by #3498

@jorg-vr jorg-vr closed this as completed May 24, 2022
Repository owner moved this from Todo to Done in Roadmap May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working medium priority Things we want to see implemented relatively soon
Projects
Status: Done
Development

No branches or pull requests

5 participants