Reduce the nummer of else clauses

dodona-edu · Oct 21, 2024 · 2d87425 · 2d87425
1 parent ca9b09e
commit 2d87425
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/app/helpers/renderers/feedback_table_renderer.rb b/app/helpers/renderers/feedback_table_renderer.rb
@@ -322,17 +322,13 @@ def messages(msgs)
   def with_differ_class(t)
     if t[:format] == 'csv'
       begin
-        if CsvDiffer.limited_columns?(t[:generated]) && CsvDiffer.limited_columns?(t[:expected])
-          yield(CsvDiffer)
-        else
-          yield(TextDiffer)
-        end
+        return yield(CsvDiffer) if CsvDiffer.limited_columns?(t[:generated]) && CsvDiffer.limited_columns?(t[:expected])
       rescue CSV::MalformedCSVError
-        yield(TextDiffer)
+        # use the default differ
       end
-    else
-      yield(TextDiffer)
     end
+
+    yield(TextDiffer)
   end
 
   def test_accepted(t)