Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-theme-docz): removed unused gatsby-plugin-manifest #1368

Merged
merged 1 commit into from
Jan 27, 2020

Conversation

alchi126
Copy link
Contributor

Description

gatsby-theme-docz has a dependency on gatsby-plugin-manifest, which in turn relies on a package called sharp that's causes install issues on Windows x64 machines.

As gatsby-plugin-manifest serves a specific use case (see specs here) and is actually never used in gatsby-theme-docz, it'd be a great help to remove it from the theme all together.

@rakannimer
Copy link
Contributor

Good catch ! Thanks 👍

@rakannimer rakannimer changed the title fix: removed unused dependency in gatsby-theme-docz fix(gatsby-theme-docz): removed unused gatsby-plugin-manifest Jan 27, 2020
@rakannimer rakannimer merged commit 44edc68 into doczjs:master Jan 27, 2020
@alchi126
Copy link
Contributor Author

Thanks for the merge, and all the great work you've been doing with docz!

@alchi126
Copy link
Contributor Author

When is the next release expected to be? Due to external download restrictions on my work machine I could only get the package via npm.

On a related note: docz also has an unused dependency on gatsby-theme-docz. I don't think it'd cause any issues, providing the version gets bumped after the next release of gatsby-theme-docz, but I'll gladly submit a PR to remove if it helps.

@wj2061
Copy link

wj2061 commented Mar 25, 2020

I can't use [email protected] for the same reason , now I have to use [email protected] instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants