-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ApiException#getResponseObject is now a serialized PHP object #83
Comments
The break looks like it is being caused by this new bit of code: https://github.com/docusign/docusign-php-client/blob/master/src/Client/ApiClient.php#L326 I think the intention was the serialized data would be unpacked into something more meaningful (determined by the HTTP response code) by whichever code is calling But I don't think |
This isn't really a question. This is an undocumented breaking change. |
Thank you for raising this issue. I have filed internal report DCM-3466. I will also ask for a new regression test to be added. |
Hi @nie7321 , To install it: Please validate from your side and let us know if you still face the issue. |
Fixed in v5.5. Please re-open if this is still an issue. Thank you |
In v3.0.1, calling
ApiException#getResponseObject()
would return anErrorDetails
object:In the v4.0.0 release, this now returns a serialized PHP object as a string:
The breaking changes section in the change notes do not mention this change, so I have to ask if it was intended or if this is a bug?
The text was updated successfully, but these errors were encountered: