Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApiException#getResponseObject is now a serialized PHP object #83

Closed
nie7321 opened this issue Jul 11, 2019 · 5 comments
Closed

ApiException#getResponseObject is now a serialized PHP object #83

nie7321 opened this issue Jul 11, 2019 · 5 comments

Comments

@nie7321
Copy link

nie7321 commented Jul 11, 2019

In v3.0.1, calling ApiException#getResponseObject() would return an ErrorDetails object:

Screen Shot 2019-07-11 at 8 02 59 AM

In the v4.0.0 release, this now returns a serialized PHP object as a string:

Screen Shot 2019-07-11 at 7 56 21 AM

The breaking changes section in the change notes do not mention this change, so I have to ask if it was intended or if this is a bug?

@nie7321
Copy link
Author

nie7321 commented Jul 11, 2019

The break looks like it is being caused by this new bit of code: https://github.com/docusign/docusign-php-client/blob/master/src/Client/ApiClient.php#L326

I think the intention was the serialized data would be unpacked into something more meaningful (determined by the HTTP response code) by whichever code is calling callApi?

But I don't think ObjectSerializer#deserialize() actually handles PHP-serialized objects?

@nie7321
Copy link
Author

nie7321 commented Jul 22, 2019

This isn't really a question. This is an undocumented breaking change.

@LarryKlugerDS
Copy link
Contributor

Thank you for raising this issue. I have filed internal report DCM-3466. I will also ask for a new regression test to be added.

@dbbrahmbhatt
Copy link
Contributor

Hi @nie7321 ,
we have fixed this for the forthcoming 5.5 release. Currently thats the 5.5.0-RC release -- RC means Release Candidate.

To install it: composer require docusign/esign-client:v5.5.0-rc

Please validate from your side and let us know if you still face the issue.

@LarryKlugerDS
Copy link
Contributor

Fixed in v5.5. Please re-open if this is still an issue. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants