Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8+ Error, missing #[\ReturnTypeWillChange] on EnvelopeTemplateDefinition #214

Closed
Caster000 opened this issue Nov 29, 2023 · 3 comments · May be fixed by #215
Closed

PHP 8+ Error, missing #[\ReturnTypeWillChange] on EnvelopeTemplateDefinition #214

Caster000 opened this issue Nov 29, 2023 · 3 comments · May be fixed by #215

Comments

@Caster000
Copy link

Hello,

Using the latest version of the SDK, 6.18, there is an error on prod environment.

PHP Fatal error: During inheritance of ArrayAccess: Uncaught ErrorException: Return type of DocuSign\eSign\Model\EnvelopeTemplateDefinition::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in vendor/docusign/esign-client/src/Model/EnvelopeTemplateDefinition.php:564

It seems like this issue already happened and was fixed in 6.7.1: #165

But I think that the Model EnvelopeTemplateDefinition was forgotten in the PR because adding the attribute #[\ReturnTypeWillChange] to the methods solve the issue:

  • offsetSet($offset, $value)
  • offsetUnset($offset)
  • offsetExists($offset)
  • offsetGet($offset)
@smd9788
Copy link

smd9788 commented Nov 29, 2023

@Caster000 - How is this error being triggered for you? Does it occur when a certain method is invoked or during the build?

@Caster000
Copy link
Author

It is triggered during the build on prod environment.

@smd9788
Copy link

smd9788 commented Jan 5, 2024

@Caster000 - I've tried various tests in a NA3 production account using SDK version 6.18.0 and have not been able to reproduce this error. Can you provide the steps you are taking to reproduce the error?

@smd9788 smd9788 closed this as completed Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants