Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back throws annotation to getSingleScalarResult #10907

Merged
merged 1 commit into from
Aug 13, 2023
Merged

Add back throws annotation to getSingleScalarResult #10907

merged 1 commit into from
Aug 13, 2023

Conversation

darenas31415
Copy link
Contributor

Fix regression introduced in #10870

$result = $this->execute(null, $hydrationMode); in getSingleResult can still throw NoResultException exception.

@darenas31415
Add back throws annotation to getSingleScalarResult
3bf0bfc 
Fix regression introduced in #10870

`$result = $this->execute(null, $hydrationMode);` in `getSingleResult` can still throw NoResultException exception.
@derrabus derrabus added this to the 2.16.2 milestone Aug 11, 2023
@derrabus derrabus merged commit 5577d51 into doctrine:2.16.x Aug 13, 2023
derrabus added a commit that referenced this pull request Aug 23, 2023
@derrabus
Merge branch '2.16.x' into 2.17.x
b6441b4 
* 2.16.x:
  Use required classes for Lifecycle Callback examples (#10916)
  Add space before backquote (#10918)
  Add back throws annotation to getSingleScalarResult (#10907)
  Fix link on known issues docs (#10904)
@github-actions github-actions bot mentioned this pull request Aug 28, 2023
Merged
@VincentLanglet VincentLanglet mentioned this pull request Aug 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Static Analysis
Projects
None yet
Milestone
2.16.2
Development

Successfully merging this pull request may close these issues.
2 participants
@darenas31415 @derrabus