Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AttributeOverride annotation is also an attribute but that is not reachable #9174

Closed
brzuchal opened this issue Nov 3, 2021 · 2 comments
Closed

AttributeOverride annotation is also an attribute but that is not reachable #9174

brzuchal opened this issue Nov 3, 2021 · 2 comments
Milestone
2.11.0

Comments

@brzuchal
Copy link

brzuchal commented Nov 3, 2021

Bug Report

Annotation AttributeOverride carry #[Attribute] attribute unreasonably.

Q A
BC Break no
Version 2.10.x

Summary

Currently AttributeOverride is an annotation but the class declaration also consists of #[Attribute] attributes.
This implies a false impression for the attribute to be usable while it's false because there is no way to apply it nor class constructor which could be used on entity class as an attribute.
@beberlei beberlei added this to the 2.11.0 milestone Nov 7, 2021
@beberlei
Copy link
Member

beberlei commented Nov 7, 2021

Planing this for 2.11 as a larger improvement to AttributeDriver with PHP 8.1 and nested attributes.

@usu usu mentioned this issue Nov 27, 2021
Closed
@beberlei beberlei mentioned this issue Dec 12, 2021
Closed
@beberlei
Copy link
Member

Fixed in #9240

@github-actions github-actions bot mentioned this issue Jan 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.11.0
Development

No branches or pull requests
2 participants
@beberlei @brzuchal