Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Phpstan job to pass with DBAL 3 #8885

Closed
greg0ire opened this issue Aug 5, 2021 · 0 comments · Fixed by #8915 or #8897
Closed

Get Phpstan job to pass with DBAL 3 #8885

greg0ire opened this issue Aug 5, 2021 · 0 comments · Fixed by #8915 or #8897

Comments

@greg0ire
Copy link
Member

greg0ire commented Aug 5, 2021

Recently, a CI job was added on the 2.10.x branch to statically analyze this project after forcing the installation of doctrine/dbal v3.

In order not to disrupt contributors, we made sure it would not fail the build although it really does not pass at all:

continue-on-error: "${{ matrix.status == 'experimental' }}"

If you want to help us fix it or get closer to fixing it, you can reproduce the failures locally by running (from the 2.10.x branch)

composer require doctrine/dbal ^3.0
vendor/bin/phpstan

When this issue is fixed, we should create a new one about making this job no longer experimental.

@greg0ire greg0ire changed the title Get Phpstan job to pass Get Phpstan job to pass with DBAL 3 Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant