Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDC-1739: [GH-314] [WIP] Doctrine\Common metadata drivers reuse #2389

Closed
doctrinebot opened this issue Mar 30, 2012 · 10 comments
Closed

DDC-1739: [GH-314] [WIP] Doctrine\Common metadata drivers reuse #2389

doctrinebot opened this issue Mar 30, 2012 · 10 comments
Assignees
Milestone

Comments

@doctrinebot
Copy link

Jira issue originally created by user @beberlei:

This issue is created automatically through a Github pull request on behalf of Ocramius:

Url: #314

Message:

This PR is strictly related with doctrine/common#98 and tests won't pass until the doctrine-common submodule points to a merged version of it (will do so later, so please don't merge now ).

Basically, I just stripped any code duplicate of what already available in dcom master under Doctrine\Common\Persistence\Mapping\Driver.

Tests are OK on my environment when using the new commons submodule.

(This is a cleanup for #263, where I sadly did pull from the remote branch after rebasing)

Tests are still failing.

@doctrinebot
Copy link
Author

Comment created by @beberlei:

A related Github Pull-Request [GH-314] was synchronize
#314

7 similar comments
@doctrinebot
Copy link
Author

Comment created by @beberlei:

A related Github Pull-Request [GH-314] was synchronize
#314

@doctrinebot
Copy link
Author

Comment created by @beberlei:

A related Github Pull-Request [GH-314] was synchronize
#314

@doctrinebot
Copy link
Author

Comment created by @beberlei:

A related Github Pull-Request [GH-314] was synchronize
#314

@doctrinebot
Copy link
Author

Comment created by @beberlei:

A related Github Pull-Request [GH-314] was synchronize
#314

@doctrinebot
Copy link
Author

Comment created by @beberlei:

A related Github Pull-Request [GH-314] was synchronize
#314

@doctrinebot
Copy link
Author

Comment created by @beberlei:

A related Github Pull-Request [GH-314] was synchronize
#314

@doctrinebot
Copy link
Author

Comment created by @beberlei:

A related Github Pull-Request [GH-314] was synchronize
#314

@doctrinebot
Copy link
Author

Comment created by @doctrinebot:

A related Github Pull-Request [GH-314] was closed:
doctrine/common#314

@malukenho
Copy link

@Ocramius it was solved on doctrine/common@dc1655b

@Ocramius Ocramius added this to the 2.5 milestone Jan 5, 2017
@Ocramius Ocramius closed this as completed Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants