-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDC-1739: [GH-314] [WIP] Doctrine\Common metadata drivers reuse #2389
Comments
7 similar comments
Comment created by @doctrinebot: A related Github Pull-Request [GH-314] was closed: |
@Ocramius it was solved on doctrine/common@dc1655b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jira issue originally created by user @beberlei:
This issue is created automatically through a Github pull request on behalf of Ocramius:
Url: #314
Message:
This PR is strictly related with doctrine/common#98 and tests won't pass until the doctrine-common submodule points to a merged version of it (will do so later, so please don't merge now ).
Basically, I just stripped any code duplicate of what already available in dcom master under Doctrine\Common\Persistence\Mapping\Driver.
Tests are OK on my environment when using the new commons submodule.
(This is a cleanup for #263, where I sadly did pull from the remote branch after rebasing)
Tests are still failing.
The text was updated successfully, but these errors were encountered: