Enum field mapping validation

[yceruto]

The recently properties types validation implemented in #10946 is not working properly for enum mappings:

$ bin/console doctrine:schema:validate

Mapping

[FAIL] The entity-class App\Model\Product mapping is invalid:

• The field 'App\Model\Product#status' has the property type 'App\Model\ProductStatus' that differs from the metadata field type 'string' returned by the 'string' DBAL type.

orm/lib/Doctrine/ORM/Tools/SchemaValidator.php

Lines 384 to 387 in 16028e4

	// If the property type is the same as the metadata field type, we are ok
	if ($propertyType === $metadataFieldType) {
	return null;
	}

where $propertyType is a BackedEnum class and $metadataFieldType is string or int.

Possible solution

I'd add another check (just below that block) to validate the enum mapping, something like this worked for me:

if (
    is_a($propertyType, BackedEnum::class, true)
    && isset($fieldMapping['enumType'])
    && $propertyType === $fieldMapping['enumType']
    && $metadataFieldType === get_debug_type($propertyType::cases()[0]->value)
) {
    return null;
}

It checks the property type against the enumType instead, but also checks if the BackedEnum variant (string or int) matches the metadata field type.

Does it make sense to you?

Affected versions: 2.17.x+

[derrabus]

Can you provide a reproducer or a failing test for your issue? If you've already found a solution (as you apparently did), don't hesitate to open a PR with your fix and a test that fails without your fix.

[yceruto]

Here we go #11039

[W0rma]

I stumbled over this issue when using doctrine/orm:2.17.

Seems like 2.17 was released before this issue has been fixed.

[delolmo]

Having the same problem here when updating to 2.17. When trying to validate the mappings, all enumTypes started failing. They didn't on previous versions.

[stlrnz]

I can confirm this issue.