DBAL deprecation: AbstractPlatform::usesSequenceEmulatedIdentityColumns is deprecated

[dmaicher]

I noticed the following deprecation report on my projects:

Doctrine\DBAL\Platforms\AbstractPlatform::usesSequenceEmulatedIdentityColumns is deprecated. (AbstractPlatform.php:3945 called by ClassMetadataFactory.php:622, doctrine/dbal#5513, package doctrine/dbal)

This is caused by

orm/lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php

Line 622 in b52a8f8

if ($this->getTargetPlatform()->usesSequenceEmulatedIdentityColumns()) {

Is there a way to avoid this deprecation inside ClassMetadataFactory?

[greg0ire]

Cc @ruudk

[greg0ire]

The only way I can think of is making the behavior configurable. Either we continue checking, or we don't based on some boolean defined in the ORM config.

[stof]

This check is necessary to avoid breaking BC in the ORM (see that when this method returns true, we reach a deprecated path).

What we need is to find a way to detect the cases non-deprecated case in a non-deprecated way, to avoid reporting a deprecation in that case.

[greg0ire]

Do you mean reimplementing this with instanceof checks? That does not sound too great 🤔 It would be cool if we could ignore that deprecation, but just once (or rather as many times as going on that codepath). But I don't think doctrine/deprecations allows that. Right now, only end users are supposed to call Deprecation::ignore* I think.

[itinance]

For what I found in the official documentation, the recommended way of generating Primary Keys with auto-generated values in PostgreSQL is

 integer primary key generated always as identity

See: https://wiki.postgresql.org/wiki/Don%27t_Do_This#Don.27t_use_serial
So no SERIAL, no SEQUENCEs, instead IDENTITY.

The strategy IDENTITY is neither providing this syntax nor usable thanks to deprecated-messages.

Is there anything available that we don't need to patch Migration-Files manually?

[stof]

What we would need for PostgreSQL is updating the PostgreSQLPlatform to use the new way of creating identity columns for PostgreSQL 10+

[greg0ire]

@itinance I'm afraid you'll be stuck until doctrine/dbal 4 is available.