From 9130b27acaa454a909dab56dc2fd128513385a11 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gr=C3=A9goire=20Paris?= Date: Tue, 27 Sep 2022 13:35:13 +0200 Subject: [PATCH] Remove return type override In the parent class, all 3 methods are documented to return mixed. This was not forward compatible with the addition of return types. --- lib/Doctrine/ORM/Persisters/SqlValueVisitor.php | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/lib/Doctrine/ORM/Persisters/SqlValueVisitor.php b/lib/Doctrine/ORM/Persisters/SqlValueVisitor.php index 301ab273c2f..a61d0a25f86 100644 --- a/lib/Doctrine/ORM/Persisters/SqlValueVisitor.php +++ b/lib/Doctrine/ORM/Persisters/SqlValueVisitor.php @@ -23,7 +23,7 @@ class SqlValueVisitor extends ExpressionVisitor /** * Converts a comparison expression into the target query language output. * - * @return void + * {@inheritDoc} */ public function walkComparison(Comparison $comparison) { @@ -32,35 +32,39 @@ public function walkComparison(Comparison $comparison) $operator = $comparison->getOperator(); if (($operator === Comparison::EQ || $operator === Comparison::IS) && $value === null) { - return; + return null; } elseif ($operator === Comparison::NEQ && $value === null) { - return; + return null; } $this->values[] = $value; $this->types[] = [$field, $value, $operator]; + + return null; } /** * Converts a composite expression into the target query language output. * - * @return void + * {@inheritDoc} */ public function walkCompositeExpression(CompositeExpression $expr) { foreach ($expr->getExpressionList() as $child) { $this->dispatch($child); } + + return null; } /** * Converts a value expression into the target query language part. * - * @return void + * {@inheritDoc} */ public function walkValue(Value $value) { - return; + return null; } /**