From 3f2091c77b569be285a6ce72a3348757bf2f6a62 Mon Sep 17 00:00:00 2001 From: David ALLIX Date: Sun, 12 Dec 2021 16:13:57 +0100 Subject: [PATCH] Review fixes --- lib/Doctrine/ORM/Query/Parser.php | 2 +- tests/Doctrine/Tests/ORM/Query/SelectSqlGenerationTest.php | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/lib/Doctrine/ORM/Query/Parser.php b/lib/Doctrine/ORM/Query/Parser.php index 6b52d2fe65a..edd3d67cd38 100644 --- a/lib/Doctrine/ORM/Query/Parser.php +++ b/lib/Doctrine/ORM/Query/Parser.php @@ -2761,7 +2761,7 @@ public function Literal() /** * InParameter ::= ArithmeticExpression | InputParameter * - * @return AST\InputParameter|AST\Literal + * @return AST\InputParameter|AST\ArithmeticExpression */ public function InParameter() { diff --git a/tests/Doctrine/Tests/ORM/Query/SelectSqlGenerationTest.php b/tests/Doctrine/Tests/ORM/Query/SelectSqlGenerationTest.php index 1e2d337ba4a..03c04d67fe3 100644 --- a/tests/Doctrine/Tests/ORM/Query/SelectSqlGenerationTest.php +++ b/tests/Doctrine/Tests/ORM/Query/SelectSqlGenerationTest.php @@ -650,6 +650,12 @@ public function testCustomFunctionWithinInExpression() : void "SELECT u FROM Doctrine\Tests\Models\Forum\ForumUser u WHERE u.username IN (FOO('Lo'), 'Lo', :name)", <<<'SQL' SELECT f0_.id AS id_0, f0_.username AS username_1 FROM forum_users f0_ WHERE f0_.username IN (ABS('Lo'), 'Lo', ?) +SQL + ); + $this->assertSqlGeneration( + "SELECT u FROM Doctrine\Tests\Models\Forum\ForumUser u WHERE u.id IN (1+1)", + <<<'SQL' +SELECT f0_.id AS id_0, f0_.username AS username_1 FROM forum_users f0_ WHERE f0_.id IN (1+1) SQL ); }