Favour int over int_id #2185
Merged
Favour int over int_id #2185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malarzm
commented
May 18, 2020
UPGRADE-2.1.md
Outdated
| The `boolean` and `integer` mapping types have been deprecated. Use their shorthand counterparts: `bool` and `int` | ||
| respectively. | ||
| The `boolean`, `integer`, and `int_id` mapping types have been deprecated. Use their shorthand counterparts: `bool` and | ||
| `int` respectively. |
There was a problem hiding this comment.
Not sure if this still makes sense?
There was a problem hiding this comment.
You could add a second sentence explaining that the int_id and int types are equivalent.
alcaeus
approved these changes
May 19, 2020
UPGRADE-2.1.md
Outdated
| The `boolean` and `integer` mapping types have been deprecated. Use their shorthand counterparts: `bool` and `int` | ||
| respectively. | ||
| The `boolean`, `integer`, and `int_id` mapping types have been deprecated. Use their shorthand counterparts: `bool` and | ||
| `int` respectively. |
There was a problem hiding this comment.
You could add a second sentence explaining that the int_id and int types are equivalent.
alcaeus
approved these changes
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #2183