Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge release 1.3.6 into 2.0.x #2151

Merged
merged 2 commits into from
Jan 13, 2020
Merged

Merge release 1.3.6 into 2.0.x #2151

merged 2 commits into from
Jan 13, 2020

Commits on Dec 26, 2019

  1. Proposal: react to entity instance in subscriber 

    Before I work on this PR I would like to ask on your opinion. I find the way the subscriber is written misleading. Currently, the subsriber will try to link the ODM Document to *every* ORM Entity. With other words the subscriber is  called post load of *every* entity defined in the project. What we want is something like

```
public function postLoad(LifecycleEventArgs $eventArgs)
    {
        $entity = $eventArgs->getEntity();

        if ($entity instanceof Order) {
            // business here
        }
}
```

Am I correct or am I missing a piece of information?

Also, in this PR I would add an example of a .yaml configuration of the listener.
    @AntoniusGolly @malarzm
    AntoniusGolly authored and malarzm committed Dec 26, 2019
    Configuration menu
    Copy the full SHA
    85c296d View commit details
    Browse the repository at this point in the history

  2. Merge pull request #2143 from malarzm/gh-2093-finish 

    #2093 final touches
    @malarzm
    malarzm authored Dec 26, 2019
    Configuration menu
    Copy the full SHA
    11243e3 View commit details
    Browse the repository at this point in the history