Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DiscriminatorMap annotation undocumented upgrade change #1933

Closed
Steveb-p opened this issue Jan 16, 2019 · 2 comments
Closed

DiscriminatorMap annotation undocumented upgrade change #1933

Steveb-p opened this issue Jan 16, 2019 · 2 comments
Assignees
@alcaeus
Labels
Documentation Has PR

Comments

@Steveb-p
Copy link
Contributor

Bug Report

Q A
BC Break no
Version 2.0.0-beta1

Summary

Documentation for upgrade does not indicate that DiscrimatorMap now always requires passing full class name along with whole namespace.

Current behavior

In 1.2 version of Doctrine ODM you can pass class names in current namespace. 2.0 always requires FQCN - I'm pretty sure now it's intended behavior.

How to reproduce

Expected behavior

2.0 Upgrade docs should contain this information. Probably under changes related to annotations?
@malarzm
Copy link
Member

malarzm commented Jan 16, 2019

We should also check if deprecation is in place

@alcaeus
Copy link
Member

alcaeus commented Jan 16, 2019

Deprecation was part of #1927

@alcaeus alcaeus mentioned this issue Feb 12, 2019
Merged
@alcaeus alcaeus added the Has PR label Feb 12, 2019
@alcaeus alcaeus self-assigned this Feb 12, 2019
@alcaeus alcaeus mentioned this issue Feb 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alcaeus alcaeus

Labels
Documentation Has PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alcaeus @Steveb-p @malarzm