Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate dependency on doctrine/common #722

Closed
jwage opened this issue Jun 5, 2018 · 5 comments
Closed

Eliminate dependency on doctrine/common #722

jwage opened this issue Jun 5, 2018 · 5 comments
Assignees
Milestone

Comments

@jwage
Copy link
Member

jwage commented Jun 5, 2018

This will require doctrine/dbal 2.8 without common and the work to continue to split up doctrine/common in to separate projects has to be finished.

@jwage jwage added this to the 3.0 milestone Jun 5, 2018
@jwage jwage self-assigned this Jun 5, 2018
@stof
Copy link
Member

stof commented Jun 5, 2018

AFAIK, the only part of Doctrine Common used directly in doctrine/migrations is the event part. So as soon as that part is extracted to a dedicated package, we can change the requirement here

@jwage
Copy link
Member Author

jwage commented Jun 5, 2018

It will remove doctrine/common from doctrine/migrations directly, but it will still be pulled in by doctrine/dbal dependency until we upgrade to doctrine/dbal 2.8.

@stof
Copy link
Member

stof commented Jun 6, 2018

But until we use the event system directly, we cannot remove the direct dependency.

@goetas
Copy link
Member

goetas commented Dec 1, 2019

Do you thing that #883 addresses this issue?

@alcaeus
Copy link
Member

alcaeus commented Dec 2, 2019

This library already doesn't depend on doctrine/common anymore, so I'm closing this issue. DBAL is tracked separately.

@alcaeus alcaeus closed this as completed Dec 2, 2019
@alcaeus alcaeus removed this from the 3.0.0 milestone Dec 2, 2019
@alcaeus alcaeus assigned alcaeus and unassigned jwage Dec 2, 2019
@goetas goetas added this to the 3.0.0 milestone Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants