Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont call addClassesToCompile on PHP 7.0, its deprecated #608

Merged
merged 1 commit into from
Jan 12, 2017
Merged

Dont call addClassesToCompile on PHP 7.0, its deprecated #608

merged 1 commit into from
Jan 12, 2017

Conversation

nicolas-grekas
Copy link
Member

No description provided.

@fabpot
Copy link
Member

fabpot commented Jan 12, 2017

👍

@mikeSimonson
Copy link
Contributor

@nicolas-grekas Thanks

@mikeSimonson mikeSimonson merged commit 4418423 into doctrine:master Jan 12, 2017
@mikeSimonson mikeSimonson self-assigned this Jan 12, 2017
@mikeSimonson mikeSimonson added this to the 1.6.7 milestone Jan 12, 2017
@mikeSimonson mikeSimonson modified the milestones: 1.7, 1.6.7 Feb 21, 2017
@nicolas-grekas nicolas-grekas deleted the class-compil branch April 17, 2017 19:06
@nicolas-grekas
Copy link
Member Author

It's not deprecated in PHP 7 but in Symfony
See symfony/symfony#20668

@bobvandevijver bobvandevijver mentioned this pull request Oct 27, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mikeSimonson mikeSimonson

Labels
None yet
Projects
None yet
Milestone
1.6.7
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas-grekas @fabpot @mikeSimonson @bmlkc