Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Corrected NamingStrategy demo code to match example #6805

Merged
merged 2 commits into from
Dec 12, 2017

Conversation

yesdevnull
Copy link
Contributor

From the NamingStrategy docs:

...all column names should be upper case...

Example paragraph mentions changing column titles to upper case, yet strtolower was being used. Corrected demo code to match the instructions.

Example paragraph mentions changing column titles to upper case, yet `strtolower` was being used.
@yesdevnull yesdevnull changed the title Corrected demo code to match example [Docs] Corrected NamingStrategy demo code to match example Nov 1, 2017
@carlosbuenosvinos
Copy link
Contributor

Thanks for the contribution, @yesdevnull! In this case, I think it probably makes more sense to change the description for than the code. I would say is more typical to have lowercase table names than uppercase names, what do you think?

@yesdevnull
Copy link
Contributor Author

yesdevnull commented Dec 4, 2017

@carlosbuenosvinos likewise 😄 I will adjust accordingly.

(apologies for very late reply, didn't see the notification for this)

@Majkl578 Majkl578 merged commit a352c21 into doctrine:master Dec 12, 2017
@Majkl578
Copy link
Contributor

@yesdevnull Thanks!

@yesdevnull yesdevnull deleted the patch-1 branch December 12, 2017 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants