Improve misleading ORMInvalidArgumentException message #6801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcobucci
suggested changes
Oct 30, 2017
| /** | ||
| * @ManyToMany(targetEntity="DDC6029User", mappedBy="groups") | ||
| */ | ||
| private $users; |
There was a problem hiding this comment.
Is this needed? Let's keep only the things required by the tests
| */ | ||
| public function testIssue() | ||
| { | ||
| $user = new DDC6029User(); |
There was a problem hiding this comment.
Shouldn't we add here the expected exception and the expected exception message? Like:
$this->expectException(ORMInvalidArgumentException::class);
$this->expectExceptionMessage('Expected value of type "Doctrine\Tests\ORM\Functional\Ticket\DDC6029Group" for association field "Doctrine\Tests\ORM\Functional\Ticket\DDC6029User#$groups", got "Doctrine\Tests\ORM\Functional\Ticket\DDC6029Group2" instead.');| * Verifies that when wrong entity is persisted via relationship field, the error message does not correctly state | ||
| * the expected class name. | ||
| */ | ||
| public function testIssue() |
|
|
||
| /** | ||
| * Verifies that when wrong entity is persisted via relationship field, the error message does not correctly state | ||
| * the expected class name. |
There was a problem hiding this comment.
Please add @group with the ticket number so that we can trace things back
lcobucci
suggested changes
Oct 30, 2017
| $user = new DDC6029User(); | ||
| $user->addGroup(new DDC6029Group2()); | ||
|
|
||
| self::expectException(ORMInvalidArgumentException::class); |
There was a problem hiding this comment.
This method is not static, so we should use $this instead
| $user->addGroup(new DDC6029Group2()); | ||
|
|
||
| self::expectException(ORMInvalidArgumentException::class); | ||
| self::expectExceptionMessage('Expected value of type "Doctrine\Tests\ORM\Functional\Ticket\DDC6029Group" for association field "Doctrine\Tests\ORM\Functional\Ticket\DDC6029User#$groups", got "Doctrine\Tests\ORM\Functional\Ticket\DDC6029Group2" instead.'); |
There was a problem hiding this comment.
This method is not static, so we should use $this instead
| @@ -195,11 +195,7 @@ public static function invalidIdentifierBindingEntity() | |||
| */ | |||
| public static function invalidAssociation(ClassMetadata $targetClass, $assoc, $actualValue) | |||
| { | |||
| $expectedType = 'Doctrine\Common\Collections\Collection|array'; | |||
|
|
|||
| if (($assoc['type'] & ClassMetadata::TO_ONE) > 0) { | |||
lcobucci
changed the title
lcobucci
approved these changes
Nov 26, 2017
added 2 commits
November 26, 2017 17:55
Since the UoW checks each item of a *-to-many association to ensure it has the correct type, we should never say that we expect an instance of `Doctrine\Common\Collections\Collection` or an `array`.
|
@foaly-nr1 🚢 thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #6029 (comment).