EntityManager::getReference() can return null

[BenMorel]

When the requested class has subclasses, a proxy cannot be returned, and the entity has to be loaded from the DB to figure out its actual class:

https://github.com/doctrine/doctrine2/blob/13f838f8bed021cc67e564ec1ff6e994a1a499a8/lib/Doctrine/ORM/EntityManager.php#L498-L500

Because find() is used, if the entity doesn't exist, EntityManager::getReference() therefore returns null.

I think that either:

• the return type of EntityManagerInterface::getReference() should be object|null
• or EntityManager::getReference() should throw an ORMException when the id doesn't exist

This is a PR for the first proposal, but if you prefer the second approach (BC break?) I can change the PR.

[SenseException]

getReference() is a similar method as find() and should have the same behaviour. I think null should be okay.

[lcobucci]

@BenMorel it doesn't make much sense to thrown an exception, also because:

https://github.com/doctrine/doctrine2/blob/13f838f8bed021cc67e564ec1ff6e994a1a499a8/lib/Doctrine/ORM/EntityManager.php#L494-L496

So I'd say we simply forgot to add |null on the interface, but maybe @Ocramius or @guilhermeblanco could give us some historical context here.

[Ocramius]

Yeah, this should be an `|null`

…

On 9 Oct 2017 17:35, "Luís Cobucci" ***@***.***> wrote: @BenMorel <https://github.com/benmorel> it doesn't make much sense to thrown an exception, also because: https://github.com/doctrine/doctrine2/blob/13f838f8bed021cc67e564ec1ff6e9 94a1a499a8/lib/Doctrine/ORM/EntityManager.php#L494-L496 So I'd say we simply forgot to add |null on the interface, but maybe @Ocramius <https://github.com/ocramius> or @guilhermeblanco <https://github.com/guilhermeblanco> could give us some historical context here. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6755 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJakOf6ZvwIIvcBppF-kbvZTr4Zp1mdks5sqj02gaJpZM4PuVFS> .

[lcobucci]

@BenMorel 🚢