Add DateInterval type parameter #6734
Conversation
|
Looks good to me. We need to plan something smarter for ORM v3 (maybe a replaceable infer mechanism? |
|
Tests with the lowest dependencies didn't pass: https://travis-ci.org/doctrine/doctrine2/jobs/280750301 |
|
Bumping dependency version for 2.6.x is quite OK
…On 28 Sep 2017 10:06, "Gocha Ossinkine" ***@***.***> wrote:
Tests with the lowest dependencies didn't pass: https://travis-ci.org/
doctrine/doctrine2/jobs/280750301
Should I increase the version in composer.json or add the version check in
the class?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#6734 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJakImZk-LhM4lMDMcKo2qAUP0bPoBzks5sm1NqgaJpZM4Pm0FT>
.
|
ossinkine
force-pushed
the
issue-6734
branch
from
ff2d81f to
4fdbdab
Compare
| [[2], Connection::PARAM_INT_ARRAY], | ||
| [["foo"], Connection::PARAM_STR_ARRAY], | ||
| [["1","2"], Connection::PARAM_STR_ARRAY], | ||
| [[], Connection::PARAM_STR_ARRAY], | ||
| [true, Type::BOOLEAN], | ||
| ]; | ||
| ]; | ||
|
|
||
| if (PHP_VERSION_ID >= 50500) { |
There was a problem hiding this comment.
Unrelated, but we can simplify this since we require PHP 7.1+
| @@ -17,7 +17,7 @@ | |||
| "php": "^7.1", | |||
| "ext-pdo": "*", | |||
| "doctrine/collections": "^1.4", | |||
| "doctrine/dbal": ">=2.5-dev,<2.7-dev", | |||
| "doctrine/dbal": "^2.6", | |||
There was a problem hiding this comment.
Did we allow >=2.7-dev intentionally here or is it just accidental?
There was a problem hiding this comment.
I set it up intentionally for look at tests and they were passed, so I think it's ok.
There was a problem hiding this comment.
I think it was accidental =) It should indeed be >=2.6-dev,<2.7-dev or even >=2.6-dev,<2.8-dev
There was a problem hiding this comment.
With how carefully we're checking BC, does it even matter? Might as well use the semver operator here.
|
Nah, fine as-is
Marco Pivetta
http://twitter.com/Ocramius
http://ocramius.github.com/
…On Fri, Oct 13, 2017 at 11:31 AM, Luís Cobucci ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In composer.json
<#6734 (comment)>:
> @@ -17,7 +17,7 @@
"php": "^7.1",
"ext-pdo": "*",
"doctrine/collections": "^1.4",
- "doctrine/dbal": ">=2.5-dev,<2.7-dev",
+ "doctrine/dbal": "^2.6",
That's true... @Majkl578 <https://github.com/majkl578> @Ocramius
<https://github.com/ocramius> anything against that?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6734 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJakBbJWF_AOnZkjstYlphXXFJ_lKgVks5sry4GgaJpZM4Pm0FT>
.
|
This PR adds the ability to pass a DateInterval object as a query parameter