Move performance tests to phpbench #6575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So... what happens when we rebase |
|
@Ocramius git will be smart enough to drop commits (except for the commits with different deltas) |
|
Good enough for me then. This suite is vital for comparing ORM 2.x to ORM 3.x, so it's gonna be shipped. @lcobucci can you add a build matrix entry to run this on travis too? |
|
@Ocramius sure 😉 |
lcobucci
force-pushed
the
improvement/move-performance-tests-to-phpbench
branch
from
a8df193 to
df71bd8
Compare
|
@Ocramius done |
Also separating the execution of the tests from other tools.
lcobucci
force-pushed
the
improvement/move-performance-tests-to-phpbench
branch
from
df71bd8 to
e07c90d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked the work done in #5840 - with some minor adjustments.
Runs fine with the
PHARversion (waiting on phpbench/phpbench#476 so we can require it on composer).