Minor fixes to the 'getting started' page #6179
Conversation
biggianteye
commented
Dec 19, 2016
biggianteye
commented
- Use consistent visibility for some fields.
- Fixing path of yaml file.
- Minor grammar changes.
| @@ -717,8 +717,8 @@ the bi-directional reference: | |||
| { | |||
| // ... (previous code) | |||
|
|
|||
| private $reportedBugs = null; | |||
| private $assignedBugs = null; | |||
| protected $reportedBugs = null; | |||
There was a problem hiding this comment.
Could you explain why? All other instance variables are marked as protected. Why should these two be private?
More importantly, they were declared as protected when first added to the User class. If there is a legitimate need for the change to the visibility, let me know and I'll incorporate it into the section where the visibility changes.
There was a problem hiding this comment.
I'd rather have everything as private around the code, but if you think that protected is better for consistency (for now), I can merge the PR as-is.
Should generally strive for private in future.
There was a problem hiding this comment.
I'm not trying to advocate one over the other (though if I were, I'd go for private). I'm just trying to remove any confusion caused by modifiers changing half way through introductory documentation without any explanation.
| private $reportedBugs = null; | ||
| private $assignedBugs = null; | ||
| protected $reportedBugs = null; | ||
| protected $assignedBugs = null; |
