Add license checker to the build #6101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
reviewed
Oct 26, 2016
| @@ -25,7 +25,8 @@ | |||
| }, | |||
| "require-dev": { | |||
| "symfony/yaml": "~2.3|~3.0", | |||
| "phpunit/phpunit": "^5.4" | |||
| "phpunit/phpunit": "^5.4", | |||
| "malukenho/docheader": "^0.1.4" | |||
There was a problem hiding this comment.
@malukenho one added dependency to just check some docblocks? I'm quite against this...
|
@malukenho the fixes on the docblocks are OK, but:
|
|
@Ocramius there's some file under I agree with you about the dependency, but license is very important to OSS projects, and it's a vital part of any OSS project as it says who can use or not this code. |
|
@malukenho I'd rather strip the licence from all files than having to deal with this sort of complexity due to vogonism. It's MIT, after all, and we have signed releases, should anybody ever complain about authorship. |
added 4 commits
October 26, 2016 13:24
|
@malukenho LGTM 👍 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add license checker to buildI did separated commits in case of the license checker be considered overkill, them we can just revert it.