Scrutinizer clear code #5911
Merged
Scrutinizer clear code #5911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1155,9 +1155,9 @@ private function getCommitOrder(array $entityChangeSet = null) | |||
| } | |||
|
|
|||
| $joinColumns = reset($assoc['joinColumns']); | |||
| $isNullable = isset($joinColumns['nullable']) ? $joinColumns['nullable'] : false; | |||
| $weight = (int)empty($joinColumns['nullable']); | |||
There was a problem hiding this comment.
Consider inlining this into $calc->addDependency(, since the variable isn't used anywhere else.
There was a problem hiding this comment.
@Ocramius, ok (i think about code as comment)
Done, wait for build
|
@ReenExe thanks! Note: please be more specific with commit messages in further PRs - the current commit messages don't really explain what/why something was done :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only UnitOfWork