Multi get implementation in QueryCache #5831
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polyanin
force-pushed
the
query-cache-optimization
branch
from
d513550 to
06f8294
Compare
polyanin
changed the title
polyanin
changed the title
|
I have same issue with performance. Please merge it! |
lcobucci
reviewed
Jan 15, 2017
| foreach ($entry->result as $index => $concreteEntry) { | ||
| $entityCacheKeys[$index] = new EntityCacheKey($cm->rootEntityName, $concreteEntry['identifier']); | ||
| } | ||
| $entries = $region->getMultiple(new CollectionCacheEntry($entityCacheKeys)); |
There was a problem hiding this comment.
@Ocramius does it makes sense to extract this process to a named constructor on CollectionCacheEntry?
There was a problem hiding this comment.
Just checked...
In order to do that we would need make CollectionCacheEntry know about EntityCacheKey and now it just depends on CacheKey (abstract class), so it's better keep the dependency here.
|
|
||
| if ($this->cacheLogger !== null) { | ||
| $this->cacheLogger->entityCacheMiss($regionName, $entityKey); | ||
| $this->cacheLogger->entityCacheMiss($regionName, $entityCacheKeys[$index]); |
There was a problem hiding this comment.
We could also do something CollectionCacheEntry#get($index) here.
There was a problem hiding this comment.
We can just use CollectionCacheEntry#identifiers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
There is significant performance degradation when doctrine tries to check the cache (memcache) after fetching multiple thousands of rows. It occurs because it doesn't use memcache's multiple get function.
This modification implements multiple get cache checking as it has been done here: #954