[RFC] DDC-3979 #1555
Merged
[RFC] DDC-3979 #1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3996 We use Jira to track the state of pull requests and the versions they got |
| $this->location = $location; | ||
| } | ||
|
|
||
| public function getId() |
There was a problem hiding this comment.
Please remove any API that isn't strictly necessary
There was a problem hiding this comment.
I use the entire API for testing
There was a problem hiding this comment.
Yeah, I was suggesting moving to public properties here
|
@guilhermeblanco I confirm that this solve the issue also in my scenario (which includes primary foreign key, multiple regions, 1st 2nd level cache, ...). Great job, thank you! |
guilhermeblanco
force-pushed
the
DDC-3979
branch
from
dc9f31d to
086ecb2
Compare
guilhermeblanco
force-pushed
the
DDC-3979
branch
from
086ecb2 to
e64f44e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1544
Fix one to one inverse side cached entity association key generation