Documentation and case fixes in QueryBuilder #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3928 We use Jira to track the state of pull requests and the versions they got |
| * @param Expr\Base $dqlPart | ||
| * @param bool $append | ||
| * @param string $dqlPartName The DQL part name. | ||
| * @param object|array $dqlPart An Expr object. |
There was a problem hiding this comment.
The types can not only be Expr\Base, but also Expr\From, Expr\Comparison and Expr\OrderBy, that do not extend Expr\Base. According to the source code, it can also be array.
Ocramius
added a commit
that referenced
this pull request
Oct 1, 2015
Documentation and case fixes in QueryBuilder
|
@BenMorel thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes incorrect docblocks and method case, and adds type-hints for IDEs to understand some variable types.