Add type hint for entity manager

[bocharsky-bw]

No description provided.

[DHager]

Looks good, but I've previously had a similar change rejected for being a backwards-compatibility break. (Which is technically is, even if it only breaks code that's already pretty broken.)

[bocharsky-bw]

@DHager Could we use ObjectRepository interface for type hint?
I see some tests failed. Maybe we could fix them? Or there are another reasons don't do that?

[stof]

@bocharsky-bw EntityManager is not an ObjectRepository at all

and this change is wrong as it forbids to pass other implementations of EntityManagerInterface

[bocharsky-bw]

@stof Sorry, I don't know how could I wrote this.
I mean ObjectManager instead of ObjectRepository.

[stof]

We don't accept any object manager here. It must be an entity manager

[bocharsky-bw]

Could we use EntityManagerInterface?

[beberlei]

Yes EntityManagerInterface could work, my question is why do you want to change this code anyways? I don't see a reason to.

[bocharsky-bw]

@beberlei I think it will be clearer, won't it? In PHP we have type hint for objects and it's a good practice to use it I think. Also it will help to find bugs on initial level.

[TomasVotruba]

👍

[Ocramius]

Accepting the change, I thought a bit about possible BC breaks, but PHP doesn't care about constructor override signature changes.

[Ocramius]

👍