Update events.rst to reflect behaviour of preUpdate #1429
Conversation
|
Please correct me if I am wrong but I think this line of code is the reason it is working in this way. |
| @@ -164,7 +164,8 @@ the life-time of their registered entities. | |||
| database insert operations. Generated primary key values are | |||
| available in the postPersist event. | |||
| - preUpdate - The preUpdate event occurs before the database | |||
| update operations to entity data. It is not called for a DQL UPDATE statement. | |||
| update operations to entity data. It is not called for a DQL UPDATE statement | |||
| nor when the computed changeset is empty. | |||
There was a problem hiding this comment.
empty changeset === no update
Maybe some other precondition was unclear to you?
There was a problem hiding this comment.
empty changeset === no update
Maybe I misunderstand you but that is what I mean. This behaviour is not documented as far as I can tell.
This is the only precondition I can think of right now that seem to be undocumented but maybe there are others.
There was a problem hiding this comment.
Agree. I'll merge anyway, but consider hunting these down if you can :-)
I think we're missing a chapter on "ORM assuptions" or such...
There was a problem hiding this comment.
To clarify: when reading the documentation as it is now it is not obvious that one of the preconditions is that one more or fields need to be modified in order for this to trigger.
There was a problem hiding this comment.
I agree. I will open up new pull requests if I find more of these. Thanks for the feedback.
Update events.rst to reflect behaviour of preUpdate
|
👍 |
1 similar comment
|
👍 |
preUpdate is only triggered when there any changes made on the target entity. The documentation does not mention that as far as I can see.