From 3d10803a2e9a839035cad7b884329b5e74fb8558 Mon Sep 17 00:00:00 2001 From: Sergei Morozov Date: Sat, 27 Jun 2020 15:32:49 -0700 Subject: [PATCH 1/2] Remove a no longer needed PHP_CodeSniffer error suppression --- phpcs.xml.dist | 5 ----- 1 file changed, 5 deletions(-) diff --git a/phpcs.xml.dist b/phpcs.xml.dist index 83965949b5d..534b91cec44 100644 --- a/phpcs.xml.dist +++ b/phpcs.xml.dist @@ -105,11 +105,6 @@ lib/Doctrine/DBAL/Driver/ExceptionConverterDriver.php - - - tests/Doctrine/Tests/DBAL/Functional/Driver/IBMDB2/StatementTest.php - - lib/Doctrine/DBAL/Schema/Comparator.php From 2136c9a6ee6a60c60776fc76d5a26da3bb680708 Mon Sep 17 00:00:00 2001 From: Sergei Morozov Date: Sat, 27 Jun 2020 15:33:01 -0700 Subject: [PATCH 2/2] Remove a no longer needed PHPStan error suppression --- phpstan.neon.dist | 5 ----- 1 file changed, 5 deletions(-) diff --git a/phpstan.neon.dist b/phpstan.neon.dist index 5f168a48fcf..315d12d10de 100644 --- a/phpstan.neon.dist +++ b/phpstan.neon.dist @@ -23,11 +23,6 @@ parameters: - '~^Property Doctrine\\DBAL\\Schema\\Schema::\$_schemaConfig \(Doctrine\\DBAL\\Schema\\SchemaConfig\) does not accept default value of type false\.\z~' - '~^Return type \(int\|false\) of method Doctrine\\DBAL\\Driver\\OCI8\\OCI8Connection\:\:lastInsertId\(\) should be compatible with return type \(string\) of method Doctrine\\DBAL\\Driver\\Connection::lastInsertId\(\)~' - # https://github.com/phpstan/phpstan/issues/3527 - - - message: '~^Call to private method sqliteCreateFunction\(\) of parent class PDO\.$~' - path: %currentWorkingDirectory%/lib/Doctrine/DBAL/Driver/PDOSqlite/Driver.php - # https://github.com/phpstan/phpstan/issues/2857 # TODO: remove in 4.0.0 - '~^Parameter #2 \$registeredAliases of static method Doctrine\\DBAL\\Query\\QueryException::nonUniqueAlias\(\) expects array, array given\.\z~'