From ed87ee6ab8354155c60fec0c48cf8313778f1d76 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gabriel=20Ostroluck=C3=BD?= Date: Sat, 17 Nov 2018 15:19:53 +0100 Subject: [PATCH] Remove pdo_sqlsrv from known vendor issues list --- docs/en/reference/configuration.rst | 1 - docs/en/reference/known-vendor-issues.rst | 11 ----------- tests/Doctrine/Tests/DBAL/Functional/BlobTest.php | 5 ----- 3 files changed, 17 deletions(-) diff --git a/docs/en/reference/configuration.rst b/docs/en/reference/configuration.rst index f8eb141ba4c..4fa8991ec33 100644 --- a/docs/en/reference/configuration.rst +++ b/docs/en/reference/configuration.rst @@ -139,7 +139,6 @@ interfaces to use. It can be configured in one of three ways: extension. **Note that this driver caused problems in our tests. Prefer the oci8 driver if possible.** - ``pdo_sqlsrv``: A Microsoft SQL Server driver that uses pdo_sqlsrv PDO - **Note that this driver caused problems in our tests. Prefer the sqlsrv driver if possible.** - ``sqlsrv``: A Microsoft SQL Server driver that uses the sqlsrv PHP extension. - ``oci8``: An Oracle driver that uses the oci8 PHP extension. - ``sqlanywhere``: A SAP Sybase SQL Anywhere driver that uses the sqlanywhere PHP extension. diff --git a/docs/en/reference/known-vendor-issues.rst b/docs/en/reference/known-vendor-issues.rst index b33e80930ac..0ff6824e1db 100644 --- a/docs/en/reference/known-vendor-issues.rst +++ b/docs/en/reference/known-vendor-issues.rst @@ -179,14 +179,3 @@ liberal DateTime parser that detects the format automatically: Type::overrideType('datetime_immutable', 'Doctrine\DBAL\Types\VarDateTimeImmutableType'); Type::overrideType('datetimetz_immutable', 'Doctrine\DBAL\Types\VarDateTimeImmutableType'); Type::overrideType('time_immutable', 'Doctrine\DBAL\Types\VarDateTimeImmutableType'); - -PDO_SQLSRV: VARBINARY/BLOB columns -~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ - -The ``PDO_SQLSRV`` driver currently has a bug when binding values to -VARBINARY/BLOB columns with ``bindValue`` in prepared statements. -This raises an implicit conversion from data type error as it tries -to convert a character type value to a binary type value even if -you explicitly define the value as ``ParameterType::LARGE_OBJECT`` type. -Therefore it is highly encouraged to use the native ``sqlsrv`` -driver instead which does not have this limitation. diff --git a/tests/Doctrine/Tests/DBAL/Functional/BlobTest.php b/tests/Doctrine/Tests/DBAL/Functional/BlobTest.php index 1b3df42ec8b..02519634007 100644 --- a/tests/Doctrine/Tests/DBAL/Functional/BlobTest.php +++ b/tests/Doctrine/Tests/DBAL/Functional/BlobTest.php @@ -3,7 +3,6 @@ namespace Doctrine\Tests\DBAL\Functional; use Doctrine\DBAL\Driver\OCI8\Driver as OCI8Driver; -use Doctrine\DBAL\Driver\PDOSqlsrv\Driver as PDOSQLSrvDriver; use Doctrine\DBAL\FetchMode; use Doctrine\DBAL\ParameterType; use Doctrine\DBAL\Schema\AbstractSchemaManager; @@ -23,10 +22,6 @@ protected function setUp() { parent::setUp(); - if ($this->connection->getDriver() instanceof PDOSQLSrvDriver) { - $this->markTestSkipped('This test does not work on pdo_sqlsrv driver due to a bug. See: http://social.msdn.microsoft.com/Forums/sqlserver/en-US/5a755bdd-41e9-45cb-9166-c9da4475bb94/how-to-set-null-for-varbinarymax-using-bindvalue-using-pdosqlsrv?forum=sqldriverforphp'); - } - /** @var AbstractSchemaManager $sm */ $table = new Table('blob_table'); $table->addColumn('id', 'integer');