Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executeStatement returning int|string in phpdoc but it can return only int #5318

Closed
jacekkarczmarczyk opened this issue Mar 11, 2022 · 2 comments
Labels

Comments

@jacekkarczmarczyk
Copy link

Bug Report

Q A
Version 3.3.3

Summary

Connection::exectureStatement (https://github.com/doctrine/dbal/blob/3.3.x/src/Connection.php#L1128) declares that it can return int|string but 2 return statements (https://github.com/doctrine/dbal/blob/3.3.x/src/Connection.php#L1128 and https://github.com/doctrine/dbal/blob/3.3.x/src/Connection.php#L1160) return only int.

How to reproduce

n/a

Expected behaviour

It should return only int

@morozov
Copy link
Member

morozov commented Mar 11, 2022

A statement may have to return a string if its numeric value is greater than PHP_INT_MAX. All methods returning the number of affected rows should return int|string. See #5317 (comment).

@morozov morozov closed this as completed Mar 11, 2022
@morozov morozov closed this as not planned Won't fix, can't repro, duplicate, stale Jul 15, 2022
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants