Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utf8mb4_0900_ai_ci should be the default collation for server_version: '8.0' #4631

Closed
fmonts opened this issue May 2, 2021 · 2 comments · Fixed by #4644
Closed

utf8mb4_0900_ai_ci should be the default collation for server_version: '8.0' #4631

fmonts opened this issue May 2, 2021 · 2 comments · Fixed by #4644
Labels
Improvement MySQL Platforms
Milestone
4.0.0-beta1

Comments

@fmonts
Copy link

fmonts commented May 2, 2021

The default collation for MySQL is utf8mb4_0900_ai_ci since MySQL 8.0.1.

Doctrine is still using the older utf8mb4_unicode_ci to create new tables, when the server_version settings is set to 8.0

Feature Request

Update the default collate to the newest version, to guarantee the best out-of-the-box configuration.
@morozov
Copy link
Member

morozov commented May 11, 2021

I don't think the DBAL should be responsible for setting any platform- or even version-specific defaults. We should remove them instead which might be a breaking change.

@morozov morozov added this to the 4.0.0 milestone May 11, 2021
@morozov morozov mentioned this issue May 11, 2021
Merged
@morozov morozov linked a pull request May 13, 2021 that will close this issue
Remove defaults for MySQL table charset, collation and engine #4644
Merged
@morozov morozov closed this as completed Jun 6, 2021
@morozov morozov mentioned this issue Jul 20, 2022
Merged
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Improvement MySQL Platforms
Projects
None yet
Milestone
4.0.0-beta1
Development

Successfully merging a pull request may close this issue.

Remove defaults for MySQL table charset, collation and engine morozov/dbal
2 participants
@morozov @fmonts