Signature of wrapper Connection constructor is not enforced

[morozov]

Psalm on level 2:

ERROR: UnsafeInstantiation - lib/Doctrine/DBAL/DriverManager.php:236:16 - Cannot safely instantiate class Doctrine\DBAL\Connection with "new $class_name" as its constructor might change in child classes (see https://psalm.dev/229)
        return new $wrapperClass($params, $driver, $config, $eventManager);

[greg0ire]

A solution might be to have a static method for this, that way the LSP is enforced

[morozov]

Ideally, I'd like to turn it into a composition similar to what we did with the portability layer. Each wrapper connector class by definition may have different dependencies injected via the constructor and the only way to do that now is to pass them via $params which isn't really type-safe.

[orklah]

Note that Psalm has an annotation @psalm-consistent-constructor that will silent this Issue while making sure every child respects the original signature

[morozov]

Thanks, @orklah. That's definitely a good way to document the shortcomings of the existing API.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.