-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quote all identifiers in SQL implicitly #4385
Labels
Comments
mvorisek
changed the title
Quote identifiers implicitly
Quote all identifiers implicitly
Oct 24, 2020
mvorisek
changed the title
Quote all identifiers implicitly
Quote all identifiers in SQL implicitly
Oct 24, 2020
Does it relate to #4357 ? |
We can't quote identifiers automatically because a lot of APIs already accept a string that may be a quoted or a non-quoted identifier. At this point, we don't know if it needs to be quoted or not. This issue is tracked in #4772. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
see https://github.com/doctrine/dbal/pull/4360/files#diff-260f15d92dacb5c7db10faacb895b841a9b843c53b7b46455ae4e0a442a655a9R41
wdyt about to quote all identifiers in SQL implicitly (instead of explicitly), ie.
quoted
by default totrue
quoted
= falsequoted
tounquoted
- but this will be breaking because of changed namesI very strongly support this idea as it will prevent all issues with dangerously left unquoted/unsupported names and still allow to use unquoted names.
I propose this for 3.x
The text was updated successfully, but these errors were encountered: