-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BC Break] 2.10.1 to v2.10.2: PDOStatement::convertParamType() must be of the type int, null given #3976
Comments
I think it's caused by this line 21512f9#diff-e7dd540cfb86c74ce7361e2bd00053cfR138 from this PR #3894 |
@wuchen90 it seems yes, but as of a patch release, IMO it should not break Waiting maintainers review/comment, thank you |
A stack trace would help I think. |
I have a similar issue and can confirm that the patch linked here breaks BC. |
Thanks for confirming that. @marcingy @noniagriconomie @wuchen90 , can you please provide a stack trace? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Ah I guess we are more interested in the stack trace of dbal/lib/Doctrine/DBAL/Connection.php Line 914 in aab745e
Does phpunit only show the top exception? Or are there several of them? For now, we only know the error message of Link to the relevant piece of code: dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php Lines 76 to 85 in f08343d
|
Ah I think I have found what the stack trace should look like
|
And of course, the dbal/lib/Doctrine/DBAL/Connection.php Line 901 in 4c03ed8
executeQuery()
|
Because of this check: dbal/lib/Doctrine/DBAL/Connection.php Line 1560 in 4c03ed8
So this method must be at fault I think: dbal/lib/Doctrine/DBAL/Connection.php Line 1562 in 4c03ed8
But I don't understand how. A stack trace of the previous exception would really help. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
hi @greg0ire sorry i was mainly AFK this month what kind of stacktrace do you need, if i dump you the sf log is it usefull? I can reproduce it if you want |
@marcingy the patch above made your issue more visible I think, I'm not sure how. Anyway, I marked your messages as resolved so that we can more easily focus on OP's issue. |
@greg0ire here you are CLI
WEB
friendly ping @greg0ire here are both stack traces, thank you for your time |
Your first message contains 2 exceptions, but not the stack trace, so it doesn't really help. When in cli, use |
Will have a look later, but it looks helpful, thanks! |
I noticed that there are calls to |
Ok sure i will try on monday and report here |
Also, you motivated me to contribute this: symfony/symfony-docs#13699 🙂 |
I will review it carefuly :) edit:
@greg0ire indeed, when disabling the bundle, code works fine i will open an issue to the other repo soon, pointing to this one |
Closing in favor of the issue mentioned above, thanks |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
BC Break Report
Hello, here is my bug report, after upgrading locally
doctrine/dbal
fromv2.10.1
tov2.10.2
(patch upgrade
)Summary
Previous behaviour
Working (yes i know not the best way to write prepared query with
?
param, but not the point here :s ))Current behavior
How to reproduce
More info
Symfony 4.3.latest
PHP 7.3.17
while doing:
composer upgrade doctrine/dbal
other doctrine component updated are
I've checked the doc, this part https://www.doctrine-project.org/projects/doctrine-dbal/en/2.10/reference/data-retrieval-and-manipulation.html#doctrine-dbal-types-conversion
but my issue is more on the
bc breack
more than the doc and code rewriteThe text was updated successfully, but these errors were encountered: