Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Type system #3733

Closed
guilhermeblanco opened this issue Nov 12, 2019 · 2 comments
Closed

Improve Type system #3733

guilhermeblanco opened this issue Nov 12, 2019 · 2 comments

Comments

@guilhermeblanco
Copy link
Member

Feature Request

Q A
New Feature yes
RFC yes/no
BC Break yes/no

Summary

Our current mapping types implementation is a simple Registry. Also, Types have private final constructors, which make it impossible to implement more elaborated data types that are not necessary members of the static type map (such an example would be a LazyDataType that would require a constructor initializer and instance-level property values, which conflicts with current Type and TypeMap registry implementation.

We should implement a more powerful, TypeFactory (ideas welcome) implementation that could operate in a prototypical way (ever request builds a new Type) or a singleton-ish (every request returns same Type instance).

@guilhermeblanco guilhermeblanco added this to the 3.0.0 milestone Nov 12, 2019
@morozov morozov removed this from the 4.0.0 milestone Jun 7, 2022
@morozov
Copy link
Member

morozov commented Aug 6, 2022

Closing as a duplicate of #2841.

@morozov morozov closed this as not planned Won't fix, can't repro, duplicate, stale Aug 6, 2022
@github-actions
Copy link

github-actions bot commented Sep 6, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants