#3306 introduced at least one bug

[svycka]

Bug Report

replacing all == to === and !== to !== should not be made with cs fixer as this can cause bugs for example here:

dbal/lib/Doctrine/DBAL/Schema/Comparator.php

Line 435 in 72b4e77

if ($properties1['default'] !== $properties2['default'] ||

Q	A
BC Break	no
Version	2.9.x-dev

Summary

Becouse of #3306 change != to !== now Schema comparator return false changes

Current behaviour

incorrectly treats default value because from database it returns string '1' but schema retun integer 1 and counts as changed default value

How to reproduce

doctrine/dbal:2.9.x-dev
maraidb:10.2.14 and mariadb:10.3.10

/**
 * @ORM\Column(type="integer", options={"default" = 1})
 */
protected $fuelType;

doctrine-module orm:schema-tool:update --dump-sql
ALTER TABLE purchase CHANGE fuelType fuelType INT DEFAULT 1 NOT NULL;

Expected behaviour

doctrine-module orm:schema-tool:update --dump-sql
[OK] Nothing to update - your database is already in sync with the current entity metadata

[morozov]

@svycka it looks similar to #3336.

[svycka]

yep looks like it, sorry :)

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.