diff --git a/UPGRADE.md b/UPGRADE.md index b1d1f3a73c8..fd07b44da53 100644 --- a/UPGRADE.md +++ b/UPGRADE.md @@ -55,6 +55,10 @@ following methods are removed: The protected property `AbstractPlatform::$doctrineTypeComments` is removed as well. +## BC BREAK: Removed `Type::canRequireSQLConversion()` + +The `Type::canRequireSQLConversion()` method has been removed. + ## BC BREAK: Removed `Connection::getWrappedConnection()`, `Connection::connect()` made `protected`. The wrapper-level `Connection::getWrappedConnection()` method has been removed. The `Connection::connect()` method diff --git a/psalm.xml.dist b/psalm.xml.dist index 85709060822..6b1be01aa0b 100644 --- a/psalm.xml.dist +++ b/psalm.xml.dist @@ -46,11 +46,6 @@ See https://github.com/doctrine/dbal/pull/4317 --> - - diff --git a/src/Types/Type.php b/src/Types/Type.php index f01a8e75f34..ac8f52b88da 100644 --- a/src/Types/Type.php +++ b/src/Types/Type.php @@ -203,22 +203,6 @@ static function (Type $type): string { ); } - /** - * Does working with this column require SQL conversion functions? - * - * This is a metadata function that is required for example in the ORM. - * Usage of {@see convertToDatabaseValueSQL} and - * {@see convertToPHPValueSQL} works for any type and mostly - * does nothing. This method can additionally be used for optimization purposes. - * - * @deprecated Consumers should call {@see convertToDatabaseValueSQL} and {@see convertToPHPValueSQL} - * regardless of the type. - */ - public function canRequireSQLConversion(): bool - { - return false; - } - /** * Modifies the SQL expression (identifier, parameter) to convert to a database value. */ diff --git a/tests/Types/StringTest.php b/tests/Types/StringTest.php index 74d374ec45c..785f0a8b26e 100644 --- a/tests/Types/StringTest.php +++ b/tests/Types/StringTest.php @@ -44,7 +44,6 @@ public function testNullConversion(): void public function testSQLConversion(): void { - self::assertFalse($this->type->canRequireSQLConversion()); self::assertEquals('t.foo', $this->type->convertToDatabaseValueSQL('t.foo', $this->platform)); self::assertEquals('t.foo', $this->type->convertToPHPValueSQL('t.foo', $this->platform)); }