diff --git a/UPGRADE.md b/UPGRADE.md index 4bb40f1b73d..3a6902fbfab 100644 --- a/UPGRADE.md +++ b/UPGRADE.md @@ -10,7 +10,8 @@ awareness about deprecated code. ## BC BREAK: removed `AbstractPlatform` methods. -1. `getIdentitySequenceName()`. +1. `getIdentitySequenceName()`, +2. `usesSequenceEmulatedIdentityColumns()`. ## BC BREAK: removed support for the `NULL` value of schema asset filter. diff --git a/psalm.xml.dist b/psalm.xml.dist index 52c6eb79f7c..748d011ddcb 100644 --- a/psalm.xml.dist +++ b/psalm.xml.dist @@ -49,10 +49,7 @@ --> - - - diff --git a/src/Platforms/AbstractPlatform.php b/src/Platforms/AbstractPlatform.php index 7243e41205d..c77b635adea 100644 --- a/src/Platforms/AbstractPlatform.php +++ b/src/Platforms/AbstractPlatform.php @@ -37,7 +37,6 @@ use Doctrine\DBAL\Types; use Doctrine\DBAL\Types\Exception\TypeNotFound; use Doctrine\DBAL\Types\Type; -use Doctrine\Deprecations\Deprecation; use InvalidArgumentException; use UnexpectedValueException; @@ -2183,27 +2182,6 @@ public function supportsIdentityColumns(): bool return false; } - /** - * Whether the platform emulates identity columns through sequences. - * - * Some platforms that do not support identity columns natively - * but support sequences can emulate identity columns by using - * sequences. - * - * @deprecated - */ - public function usesSequenceEmulatedIdentityColumns(): bool - { - Deprecation::trigger( - 'doctrine/dbal', - 'https://github.com/doctrine/dbal/pull/5513', - '%s is deprecated.', - __METHOD__ - ); - - return false; - } - /** * Whether the platform supports partial indexes. */ diff --git a/src/Platforms/OraclePlatform.php b/src/Platforms/OraclePlatform.php index 5aa0c53a13b..0c43dcf7e76 100644 --- a/src/Platforms/OraclePlatform.php +++ b/src/Platforms/OraclePlatform.php @@ -16,7 +16,6 @@ use Doctrine\DBAL\Schema\TableDiff; use Doctrine\DBAL\TransactionIsolationLevel; use Doctrine\DBAL\Types\BinaryType; -use Doctrine\Deprecations\Deprecation; use InvalidArgumentException; use function array_merge; @@ -708,21 +707,6 @@ protected function getRenameIndexSQL(string $oldIndexName, Index $index, string return ['ALTER INDEX ' . $oldIndexName . ' RENAME TO ' . $index->getQuotedName($this)]; } - /** - * @deprecated - */ - public function usesSequenceEmulatedIdentityColumns(): bool - { - Deprecation::trigger( - 'doctrine/dbal', - 'https://github.com/doctrine/dbal/pull/5513', - '%s is deprecated.', - __METHOD__ - ); - - return true; - } - protected function getIdentitySequenceName(string $tableName): string { $table = new Identifier($tableName); diff --git a/src/Platforms/PostgreSQLPlatform.php b/src/Platforms/PostgreSQLPlatform.php index adcb94d31c5..b6b964c873a 100644 --- a/src/Platforms/PostgreSQLPlatform.php +++ b/src/Platforms/PostgreSQLPlatform.php @@ -150,21 +150,6 @@ public function supportsPartialIndexes(): bool return true; } - /** - * @deprecated - */ - public function usesSequenceEmulatedIdentityColumns(): bool - { - Deprecation::trigger( - 'doctrine/dbal', - 'https://github.com/doctrine/dbal/pull/5513', - '%s is deprecated.', - __METHOD__ - ); - - return true; - } - public function supportsCommentOnStatement(): bool { return true; diff --git a/tests/Platforms/AbstractPlatformTestCase.php b/tests/Platforms/AbstractPlatformTestCase.php index f097233b4e9..723f19ab0ef 100644 --- a/tests/Platforms/AbstractPlatformTestCase.php +++ b/tests/Platforms/AbstractPlatformTestCase.php @@ -692,11 +692,6 @@ public function testAlterTableChangeQuotedColumn(): void ); } - public function testUsesSequenceEmulatedIdentityColumns(): void - { - self::assertFalse($this->platform->usesSequenceEmulatedIdentityColumns()); - } - public function testGetFixedLengthStringTypeDeclarationSQLNoLength(): void { self::assertSame( diff --git a/tests/Platforms/OraclePlatformTest.php b/tests/Platforms/OraclePlatformTest.php index 49b730391f2..639aa422c58 100644 --- a/tests/Platforms/OraclePlatformTest.php +++ b/tests/Platforms/OraclePlatformTest.php @@ -492,11 +492,6 @@ public function testDoesNotPropagateUnnecessaryTableAlterationOnBinaryType(): vo ); } - public function testUsesSequenceEmulatedIdentityColumns(): void - { - self::assertTrue($this->platform->usesSequenceEmulatedIdentityColumns()); - } - /** * @dataProvider dataCreateSequenceWithCache */ diff --git a/tests/Platforms/PostgreSQLPlatformTest.php b/tests/Platforms/PostgreSQLPlatformTest.php index 0e6f6f18502..16d1d886492 100644 --- a/tests/Platforms/PostgreSQLPlatformTest.php +++ b/tests/Platforms/PostgreSQLPlatformTest.php @@ -569,11 +569,6 @@ public function testDroppingConstraintsBeforeColumns(): void self::assertEquals($expectedSql, $sql); } - public function testUsesSequenceEmulatedIdentityColumns(): void - { - self::assertTrue($this->platform->usesSequenceEmulatedIdentityColumns()); - } - /** * @dataProvider dataCreateSequenceWithCache */