From 8d8ac0ee0921ac2b190146fda9fd55ede31ae2c3 Mon Sep 17 00:00:00 2001
From: Sergei Morozov <morozov@tut.by>
Date: Tue, 7 Aug 2018 09:13:23 -0700
Subject: [PATCH] Removed dbal:import CLI command

---
 UPGRADE.md                                    |   5 +
 .../Tools/Console/Command/ImportCommand.php   | 123 ------------------
 .../DBAL/Tools/Console/ConsoleRunner.php      |   2 -
 3 files changed, 5 insertions(+), 125 deletions(-)
 delete mode 100644 lib/Doctrine/DBAL/Tools/Console/Command/ImportCommand.php

diff --git a/UPGRADE.md b/UPGRADE.md
index a6731e2ad03..fca29599cff 100644
--- a/UPGRADE.md
+++ b/UPGRADE.md
@@ -1,5 +1,10 @@
 # Upgrade to 3.0
 
+## BC BREAK: Removed dbal:import CLI command
+
+The `dbal:import` CLI command has been removed since it only worked with PDO-based drivers by relying on a non-documented behavior of the extension, and it was impossible to make it work with other drivers.
+Please use other database client applications for import, e.g. `mysql < data.sql`.
+
 ## BC BREAK: Removed support for DB-generated UUIDs
 
 The support for DB-generated UUIDs was removed as non-portable.
diff --git a/lib/Doctrine/DBAL/Tools/Console/Command/ImportCommand.php b/lib/Doctrine/DBAL/Tools/Console/Command/ImportCommand.php
deleted file mode 100644
index 48dde2c84fc..00000000000
--- a/lib/Doctrine/DBAL/Tools/Console/Command/ImportCommand.php
+++ /dev/null
@@ -1,123 +0,0 @@
-<?php
-
-namespace Doctrine\DBAL\Tools\Console\Command;
-
-use Doctrine\DBAL\Driver\PDOStatement;
-use Symfony\Component\Console\Command\Command;
-use Symfony\Component\Console\Input\InputArgument;
-use Symfony\Component\Console\Input\InputInterface;
-use Symfony\Component\Console\Output\OutputInterface;
-use const PHP_EOL;
-use function assert;
-use function file_exists;
-use function file_get_contents;
-use function is_readable;
-use function realpath;
-use function sprintf;
-
-/**
- * Task for executing arbitrary SQL that can come from a file or directly from
- * the command line.
- *
- * @link   www.doctrine-project.org
- * @since  2.0
- * @author Benjamin Eberlei <kontakt@beberlei.de>
- * @author Guilherme Blanco <guilhermeblanco@hotmail.com>
- * @author Jonathan Wage <jonwage@gmail.com>
- * @author Roman Borschel <roman@code-factory.org>
- */
-class ImportCommand extends Command
-{
-    /**
-     * {@inheritdoc}
-     */
-    protected function configure()
-    {
-        $this
-        ->setName('dbal:import')
-        ->setDescription('Import SQL file(s) directly to Database.')
-        ->setDefinition([
-            new InputArgument(
-                'file', InputArgument::REQUIRED | InputArgument::IS_ARRAY, 'File path(s) of SQL to be executed.'
-            )
-        ])
-        ->setHelp(<<<EOT
-Import SQL file(s) directly to Database.
-EOT
-        );
-    }
-
-    /**
-     * {@inheritdoc}
-     */
-    protected function execute(InputInterface $input, OutputInterface $output)
-    {
-        $conn = $this->getHelper('db')->getConnection();
-
-        if (($fileNames = $input->getArgument('file')) !== null) {
-            foreach ((array) $fileNames as $fileName) {
-                $filePath = realpath($fileName);
-
-                // Phar compatibility.
-                if (false === $filePath) {
-                    $filePath = $fileName;
-                }
-
-                if ( ! file_exists($filePath)) {
-                    throw new \InvalidArgumentException(
-                        sprintf("SQL file '<info>%s</info>' does not exist.", $filePath)
-                    );
-                } elseif ( ! is_readable($filePath)) {
-                    throw new \InvalidArgumentException(
-                        sprintf("SQL file '<info>%s</info>' does not have read permissions.", $filePath)
-                    );
-                }
-
-                $output->write(sprintf("Processing file '<info>%s</info>'... ", $filePath));
-                $sql = file_get_contents($filePath);
-
-                if ($conn instanceof \Doctrine\DBAL\Driver\PDOConnection) {
-                    // PDO Drivers
-                    try {
-                        $lines = 0;
-
-                        $stmt = $conn->prepare($sql);
-                        assert($stmt instanceof PDOStatement);
-
-                        $stmt->execute();
-
-                        do {
-                            // Required due to "MySQL has gone away!" issue
-                            $stmt->fetch();
-                            $stmt->closeCursor();
-
-                            $lines++;
-                        } while ($stmt->nextRowset());
-
-                        $output->write(sprintf('%d statements executed!', $lines) . PHP_EOL);
-                    } catch (\PDOException $e) {
-                        $output->write('error!' . PHP_EOL);
-
-                        throw new \RuntimeException($e->getMessage(), $e->getCode(), $e);
-                    }
-                } else {
-                    // Non-PDO Drivers (ie. OCI8 driver)
-                    $stmt = $conn->prepare($sql);
-                    $rs = $stmt->execute();
-
-                    if ($rs) {
-                        $output->writeln('OK!' . PHP_EOL);
-                    } else {
-                        $error = $stmt->errorInfo();
-
-                        $output->write('error!' . PHP_EOL);
-
-                        throw new \RuntimeException($error[2], $error[0]);
-                    }
-
-                    $stmt->closeCursor();
-                }
-            }
-        }
-    }
-}
diff --git a/lib/Doctrine/DBAL/Tools/Console/ConsoleRunner.php b/lib/Doctrine/DBAL/Tools/Console/ConsoleRunner.php
index 69098e2ea8e..f2d40551ac7 100644
--- a/lib/Doctrine/DBAL/Tools/Console/ConsoleRunner.php
+++ b/lib/Doctrine/DBAL/Tools/Console/ConsoleRunner.php
@@ -3,7 +3,6 @@
 namespace Doctrine\DBAL\Tools\Console;
 
 use Doctrine\DBAL\Connection;
-use Doctrine\DBAL\Tools\Console\Command\ImportCommand;
 use Doctrine\DBAL\Tools\Console\Command\ReservedWordsCommand;
 use Doctrine\DBAL\Tools\Console\Command\RunSqlCommand;
 use Doctrine\DBAL\Tools\Console\Helper\ConnectionHelper;
@@ -60,7 +59,6 @@ public static function addCommands(Application $cli)
     {
         $cli->addCommands([
             new RunSqlCommand(),
-            new ImportCommand(),
             new ReservedWordsCommand(),
         ]);
     }