diff --git a/phpcs.xml.dist b/phpcs.xml.dist index 730257c797c..b181bb0bb66 100644 --- a/phpcs.xml.dist +++ b/phpcs.xml.dist @@ -48,14 +48,6 @@ */src/Tools/Console/Helper/ConnectionHelper.php - - */src/* - - - - */src/* - - */lib/Doctrine/DBAL/Driver/PDOQueryImplementation.php */lib/Doctrine/DBAL/Driver/PDOStatementImplementations.php diff --git a/src/Connection.php b/src/Connection.php index 453a04dfcff..dfaa0059fe8 100644 --- a/src/Connection.php +++ b/src/Connection.php @@ -619,7 +619,7 @@ public function insert(string $table, array $data, array $types = []): int * * @return array|array */ - private function extractTypeValues(array $columnList, array $types) + private function extractTypeValues(array $columnList, array $types): array { $typeValues = []; diff --git a/src/Driver/OCI8/Connection.php b/src/Driver/OCI8/Connection.php index e091d5ae2e8..e69f90befca 100644 --- a/src/Driver/OCI8/Connection.php +++ b/src/Driver/OCI8/Connection.php @@ -94,7 +94,7 @@ public function exec(string $sql): int return $this->prepare($sql)->execute()->rowCount(); } - public function lastInsertId() + public function lastInsertId(): void { throw IdentityColumnsNotSupported::new(); } diff --git a/src/Platforms/SQLServerPlatform.php b/src/Platforms/SQLServerPlatform.php index 22ac067fca2..3e0fa7b1871 100644 --- a/src/Platforms/SQLServerPlatform.php +++ b/src/Platforms/SQLServerPlatform.php @@ -1473,10 +1473,7 @@ public function getListTableMetadataSQL(string $table): string ); } - /** - * @param string $query - */ - private function shouldAddOrderBy($query): bool + private function shouldAddOrderBy(string $query): bool { // Find the position of the last instance of ORDER BY and ensure it is not within a parenthetical statement // but can be in a newline