Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump doctrine/.github from 1.5.0 to 5.0.0 #415

Merged
merged 2 commits into from
May 3, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 3, 2024

Bumps doctrine/.github from 1.5.0 to 5.0.0.

Release notes

Sourced from doctrine/.github's releases.

5.0.0

Changed

  • Bumped all workflows to their latest versions. Among other things, this means codecov/codecov-action is bumped to v4, which in turn means you will have to provide a CODECOV_TOKEN secret to your workflows.

PHP 8.3 by default

Changed

  • jobs now run by default on PHP 8.3

Checkout v4

No release notes provided.

PHP 8.2, ubuntu 22.04

Changed

  • jobs now run by default on PHP 8.2
  • jobs now run on ubuntu 22.04

Dependency upgrade

All the actions we are relying on have been upgraded to their latest major version.

2.0.0

PHP 8.1 as default

All workflows are running on PHP 8.1 by default now. The "Continuous Integration" workflow runs on PHP 7.2 – 8.1 by default. Of course, you can still override this setting if you like.

Commits
  • 03e9941 Merge pull request #42 from greg0ire/forgotten-occurrence
  • 68b7e7e Provide CODECOV_TOKEN also when using the alternate CI workflow
  • 74d9928 Merge pull request #41 from greg0ire/pass-codecov-token
  • 5c61eff Pass CODECOV_TOKEN to codecov/codecov-action
  • 1dbf796 Merge pull request #40 from greg0ire/bump-all-the-things
  • 334efea Bump workflow actions
  • 8255e2f Merge pull request #39 from derrabus/improvement/stable-php-8.3
  • 0050753 PHP 8.3 is stable
  • 872bb4d Merge pull request #38 from derrabus/bump/checkout
  • 6295902 Use checkout v4
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [doctrine/.github](https://github.com/doctrine/.github) from 1.5.0 to 5.0.0.
- [Release notes](https://github.com/doctrine/.github/releases)
- [Commits](doctrine/.github@1.5.0...5.0.0)

---
updated-dependencies:
- dependency-name: doctrine/.github
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label May 3, 2024
@greg0ire
Copy link
Member

greg0ire commented May 3, 2024

Ah… Codecov errors out… I think I faintly remember something about shared workflows not being able to pull secrets 🤔

For instance for the release workflow, we explicitly pass stuff in secrets… but here the Codecov docs use env, not secrets: https://docs.codecov.com/docs/github-2-getting-a-codecov-account-and-uploading-coverage#create-ci-pipeline

@greg0ire
Copy link
Member

greg0ire commented May 3, 2024

Ah yes 💡 CODECOV_TOKEN is a secret, hence why we use it with secrets.CODECOV_TOKEN. And we have to explicitly pass it as a secret to our shared workflow.

with:
php-versions: '["8.1"]'
secrets:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow is not valid. .github/workflows/continuous-integration.yml (Line: 20, Col: 22): Invalid secret, CODECOV_TOKEN is not defined in the referenced workflow.

🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah OK I need to fix the shared workflow.

@greg0ire greg0ire force-pushed the dependabot/github_actions/doctrine/dot-github-5.0.0 branch from d8ccf0e to 9d014ae Compare May 3, 2024 20:28
@greg0ire greg0ire merged commit 98aff5e into 2.2.x May 3, 2024
8 checks passed
@dependabot dependabot bot deleted the dependabot/github_actions/doctrine/dot-github-5.0.0 branch May 3, 2024 20:33
@greg0ire greg0ire added this to the 2.2.3 milestone May 3, 2024
@greg0ire greg0ire added CI and removed dependencies Pull requests that update a dependency file labels May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant