Make manager registry resettable #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
force-pushed
the
reset-managers
branch
from
3fe9abd to
c10af52
Compare
GromNaN
commented
Aug 30, 2024
| /** @var class-string<Container> $containerClass */ | ||
| $containerClass = 'MongoDBManagerRepositoryTestResetContainer'; | ||
| $dumper = new PhpDumper($container); | ||
| eval('?' . '>' . $dumper->dump(['class' => $containerClass])); |
There was a problem hiding this comment.
The tag ?> would break GitHub syntax coloration. https://github.com/symfony/symfony/blob/76b7a7e95691d02ada1d24a6b1d9dadcab047d8d/src/Symfony/Bridge/Doctrine/Tests/ManagerRegistryTest.php#L34
dunglas
approved these changes
Aug 30, 2024
alcaeus
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue reported on Twitter: https://twitter.com/TheOnlyNeso/status/1829216833867808807
@alcaeus did the same for DoctrineBundle: doctrine/DoctrineBundle#1099 and doctrine/DoctrineBundle#1108
Resetting services is provided by Symfony Doctrine Bridge: https://github.com/symfony/symfony/blob/7.2/src/Symfony/Bridge/Doctrine/ManagerRegistry.php
I tried to add a comprehensive test.